• ###### theflyingpotatocommented on "ATM money counter" kata

This was an awesome kata was alot of fun to solve thank you

done.

• ###### trashy_incelcreated a suggestion for "ATM money counter" kata

missing `from preloaded import VALUES` in Python's initial code

• ###### trashy_incelcommented on "ATM money counter" kata

to clarify: this only happens with the Cuban Peso (`CUP`) which has denominations `[1, 3, 5, 10, 20, 50, 100]`. all other currencies seem to be
canonical

• ###### trashy_incelcommented on "ATM money counter" kata

missing `from preloaded import VALUES` in initial code for forward-compatibility

Approved

• ###### Martyn-Pearsoncreated an issue for "ATM money counter" kata

Should you have the notes of denomination 1, 3 and 5 available with a target of 6, there are two ways of making the total with the same (minimal) number of notes - 1 + 5 or 3 + 3. It appears that the tests only allow 3 + 3 and not 1 + 5 despite the same number of notes being used.
Suggest that either the text specifies that the number of denominations should also be minimal, or the tests are altered to accept either solution.

• ###### kareem802commented on "Valid Phone Number" python solution

my solution is similar but quite the opposite logic. Liked this one!

• ###### B1tsresolved a question on "ATM money counter" kata

You probably know this already, but you can print the input to console.

There are tests with strings like "EUR 200 OVISION", which is just stupid IMO.

• ###### yavorkocreated a question for "ATM money counter" kata

On JavaScript version I have this error:

"Expected: 'Sorry, have no EURYTHMICS.', instead got: 'Can't do 2853 EUR. Value must be divisible by 5!'

and on all similar tests with currency name "EUROVISION", "EURYTHMICS etc.

In my IDE I got correct results although I am not sure what the original input was.
I tried inputs like "Eurythmics2853", "2853 EURythMicS" and all got correct results.

Is it that my regex is wrong or what?
Can you give me the input for that test, please?

• ###### ozdefircommented on "Valid Phone Number" python solution

"Everyone says it's so clever!" Well, because it is clever. That minor issue could be fixed by replacing x with any number, e.g., `template = '(111) 111-1111'`; `number += '1'`

• ###### Fuzzy Logiccommented on "Valid Phone Number" python solution

elegant solution, but does not work for some cases

for example : "(12x) 456-7x90"

• ###### msulockcommented on "Valid Phone Number" python solution

Yah...This function will accept (xxx) xxx-xxxx as a valid phone number. Everyone says it's so clever! lol

• ###### user1430804commented on "ATM money counter" kata

wow.. amazing challenge !