Ad
  • Custom User Avatar

    Seems like the more readable the code gets, the worse it performs.

    It's probably because of all the references and function calls.

  • Custom User Avatar

    lol. I've checked on godbolt and we've been getting less and less efficient (at least in terms of assembly length). My initial solution was 186 lines, then 247, and yours is 504. It's not an actual speed comparison, but assuming it's a similar effect, that would show an inverse relation to legibility.

    Yours is definitely the most legible, whereas my initial minimizes the number of passes.

  • Custom User Avatar

    Is there a reason usize is not used for the return type? It seems more natural if we're going to do conversions anyways, since a negative value is meaningless. Plus now there are situations where we can't give the correct answer. [i16::MIN, i16::MAX] would product an answer of 2^16 - 2, which is way to big to fit in an i16. I guess if we're going for minmalism u16 would be the appropriate type, but would require more conversion unless the input was also &[u16].

  • Default User Avatar

    I just realized someone already beat me to it in other fork here

  • Custom User Avatar

    I understand that take, but not from a JavaScript developer. I'm intrigued. What do you think makes it worse than JavaScript?

  • Custom User Avatar

    Hmm, the descritions looked identical, but in the editor there was some weird old/===/yours formatting that I removed in the new fork. They should be identical behind the scenes too now.

  • Custom User Avatar

    It seems like there are still issues with the description. Can you fork your translation and make a small change to the description like this?

  • Custom User Avatar

    The Rust translation needs some work.

    • Tests should be in a tests module with #[cfg(test)]
    • &[_] is more idiomatic and flexible and should always be preferred over &Vec<_>
    • -> () return type is moot and discouraged.
    • The spacing should be inline with rustfmt, which leaves an empty line between functions, and spaces lists as [a, b, c] instead of [ a,b,c ].
    • The todo!() macro is a more idiomatic way to mark unwritten code, rather than a comment that fails compilation.
    • The type for a function that takes 2 i64s and returns 1 is fn(i64, i64) -> i64. The user shouldn't have to write their own function signatures.
    • The reference solution is needlessly complex.
  • Custom User Avatar
  • Custom User Avatar

    You apparently need to merge the current description into this fork. Otherwise, I can't approve it.

    Description cannot be approved, recent changes from related record must be merged first.

  • Custom User Avatar

    Rust tests are run in parallel with nondeterministic ordering, though with only two of them it would be easier enough to submit until such a solution passed. Added random tests.

  • Custom User Avatar

    Random tests just need to ensure that you can't hardcode the solution based on the order of tests.
    A function that returns 52 times true followed by 43 times false would be able to pass the fixed tests.

    See https://docs.codewars.com/authoring/guidelines/submission-tests/#random-tests

  • Custom User Avatar

    I've improved the non-sample assertion messages.

    Random tests don't do anything if the test coverage is exhaustive. Though I might have missed some characters, so please let me know. I'm assuming only ascii printable characters are included.

  • Custom User Avatar

    Could you add some random tests and assertion messages?

    The messages for the sample tests are probably fine, but the others just say assertion failed: is_it_letter(c).
    You could do it like this: assert!(is_it_letter(c), "is_it_letter('{}') wasn't true", c);.

  • Custom User Avatar

    Good work!

    A few notes if you're interested (ignore if not):

    • unit () return type is typically omitted
    • random tests don't do much when you're testing the same function on the left and right side
    • the later arguments in assert_eq! are already equivalent to format!

    Forked with these changes and a few more. Feel free to ask me if you have any questions.

  • Loading more items...