My comments:
labelDepth
runWriterMonoid
runWriterList
Free (Writer w) a
w
This comment is hidden because it contains spoiler information about the solution
added test cases
Very nice kata, I feel I learned a lot!
A good kata! But tests should be improved:
No random tests for local, labelDepth.
local
modify is not tested.
modify
Challenging but also interesting and satisfying! Would love to see more payoff at the end, e.g. using the monad instances in example computations.
Loading collection data...
My comments:
labelDepth
a bit more detailed description would be nice.runWriterMonoid
means just the opposite of the expected one, especially for lists.runWriterMonoid
andrunWriterList
it would be good to add thatFree (Writer w) a
is also a functor inw
.This comment is hidden because it contains spoiler information about the solution
This comment is hidden because it contains spoiler information about the solution
added test cases
Very nice kata, I feel I learned a lot!
A good kata! But tests should be improved:
No random tests for
local
,labelDepth
.modify
is not tested.Challenging but also interesting and satisfying! Would love to see more payoff at the end, e.g. using the monad instances in example computations.