Ad
  • Custom User Avatar

    Some items below should be raised as an issue but aren't:

    • Output format for currency is unspecified. You cannot expect everyone to magically know what built-in method to use to get that result
    • Edge case and expected rounding is unspecified (Why are ratings rounded?)
    • JS naming convention: function name should be in camelCase instead of snake_case
    • Test assertion is incorrectly done: comparing properties one by one means the tests will no longer test the remaining properties if the first one fails. assert.deepEqual exist for performing deep comparison between objects
  • Custom User Avatar

    As usual, please do not create a kata that depends on external resources managed by unknown entities. As far as the current kata design goes, as soon as the data changes on their side the tests will be broken and unpassable.

    Related to the above: there are no random tests.

  • Custom User Avatar

    you're going to buy everything that is between a given range of prices

    Is this range exclusive or inclusive?

    Also, what is a and b? This isn't mentioned in the description either. (And this isn't a code golf kata, so can we have better input argument names?)

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    Wrong!: expected '3.406,00 €' to equal '3.406,00 €'

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    Hi,

    You should change the title: Defuse the bombs!

    Cheers