this is specific to the sample tests, as otherwise it would spoil the solution, as you guessed. i could hide the testing code in preloaded, but I do not like it, the user is supposed to read the sample tests to understand how their code is run. I could use a macro to wrap the representation of the float, but I'm afraid beginners would not understand what's happening. do you have a suggestion ?
The "make it easier" feature with Latin script was removed. Now num_to_russian() requires Cyrillic outputs and russian_to_num() always receives Cyrillic inputs.
The Floats section was updated, with much simpler "whole units" and "-ths".
Every dictionary removed.
Also fixed a bug with "одна тысяча" outputting "2000" for some reason.
Thanks for your honest opinion and not frowning upon the kata for those issues.
Writing this through my phone, no access to the laptop.
I have noticed the tendency of people creating their own dictionaries for this kata, instead of using the given ones. And honestly, I don't blame them. The current description is still a complete dogwater, even after so many issues resolved.
I'm highly considering on removing the dictionaries entirely and make the description only in Latin. For Russian speakers, I will just put a disclaimer, saying that they don't have to read the following instructions and that the Cyrillic inputs will be valid. But I have a dilemma with russian_to_num(). Should I keep its inputs Cyrillic or change it to Latin?
If you have any more suggestions or you see a problem in my considerations, please, share them. When I arrive home, I'll get on fixing them, since this kata was abandoned by me since the end of May.
When there's a misspelling, it's difficult to know whether the case should be preserved without considering wider context, for example is it the first word of a sentence? But you're right that my solution assumes that the case should be preserved if it's a single letter. Let me modify the description to clarify this.
Modified the description to "Characters in a misspelled word that are in the correct position preserve their case. Incorrect characters should be corrected to be lowercase, unless the misspelled word is entirely uppercase and longer than one character."
The case doesn't depend on the correction, because the rule is: "Correct characters in a misspelled word preserve their case. Incorrect characters should be corrected to be lowercase, unless the misspelled word is entirely uppercase and longer than one character." Since the "BE" are not "correct", because they're in the wrong place, they need to be corrected to lowercase. The "ING" are correct, so the correction is "ill-beING". (Maybe I should clarify that "correct" means being in the correct position?)
Deciding on the rule for case corrections was the hardest thing in creating the kata, because there are different possibilities, and it's not clear which is best.
I updated the assertion messages, can you check it out ?
this is specific to the sample tests, as otherwise it would spoil the solution, as you guessed. i could hide the testing code in preloaded, but I do not like it, the user is supposed to read the sample tests to understand how their code is run. I could use a macro to wrap the representation of the float, but I'm afraid beginners would not understand what's happening. do you have a suggestion ?
I've updated the kata:
num_to_russian()requires Cyrillic outputs andrussian_to_num()always receives Cyrillic inputs.Floatssection was updated, with much simpler "whole units" and "-ths".Thanks for your honest opinion and not frowning upon the kata for those issues.
Writing this through my phone, no access to the laptop.
I have noticed the tendency of people creating their own dictionaries for this kata, instead of using the given ones. And honestly, I don't blame them. The current description is still a complete dogwater, even after so many issues resolved.
I'm highly considering on removing the dictionaries entirely and make the description only in Latin. For Russian speakers, I will just put a disclaimer, saying that they don't have to read the following instructions and that the Cyrillic inputs will be valid. But I have a dilemma with
russian_to_num(). Should I keep its inputs Cyrillic or change it to Latin?If you have any more suggestions or you see a problem in my considerations, please, share them. When I arrive home, I'll get on fixing them, since this kata was abandoned by me since the end of May.
I've updated the description with a detailed specification of the input.
When there's a misspelling, it's difficult to know whether the case should be preserved without considering wider context, for example is it the first word of a sentence? But you're right that my solution assumes that the case should be preserved if it's a single letter. Let me modify the description to clarify this.
Modified the description to "Characters in a misspelled word that are in the correct position preserve their case. Incorrect characters should be corrected to be lowercase, unless the misspelled word is entirely uppercase and longer than one character."
The case doesn't depend on the correction, because the rule is: "Correct characters in a misspelled word preserve their case. Incorrect characters should be corrected to be lowercase, unless the misspelled word is entirely uppercase and longer than one character." Since the "BE" are not "correct", because they're in the wrong place, they need to be corrected to lowercase. The "ING" are correct, so the correction is "ill-beING". (Maybe I should clarify that "correct" means being in the correct position?)
Deciding on the rule for case corrections was the hardest thing in creating the kata, because there are different possibilities, and it's not clear which is best.
Thank you for the feedback! I tried addressing these issues. Hope the kata is better now.
.
Approved.
Reraised as an issue
You linked to "proposals", is this still in beta?
fixed there
Resolved :)
Loading more items...