• ###### seraph776commented on "Find Billy's Special Number" kumite

Hi there, cool kumite! Perhaps you should update the instructions to include: 'If a copy of special is already in the array, then remove it before inserting special again and then return the new array.'

• ###### seraph776commented on "shortest word reverse [lambda with test cases] without slices" kumite

Hmph, I think my version is way faster than yours! 😁

Cool! 👍

Great job!

• ###### seraph776commented on "Ordinal Numbers" kumite

Thanks for the catch!

• ###### seraph776commented on "Palindrome" kumite

Pretty clever useage!

• ###### seraph776commented on "Palindrome" kumite

You have to add test cases

• ###### seraph776commented on "How Many Songs You Can Play?" kumite

If the input array represents the durations of songs in `seconds` of each song, and there is `1` minute between each song, how does
[420, 180, 360, 240, 120, 240, 300, 180] equal `59 minutes and 15 seconds`? The sum of the array is `2040` seconds + `7` minutes, (or `420` seconds) for time between songs equals `2460` seconds or `41` minutes, correct? Likewise with the third example: [300, 240, 480, 180, 240, 240, 300, 360], how did this calculate to `57 minutes and 40 seconds`? ~ Thanks for any clarification!

• ###### seraph776commented on "Storing information about the user" kumite

As you can see - typehint for _field_no_pipe: str = None was not applied for help docstring

Thank you for your feedback! I may be over looking what you're trying to explain. On line `533` of your example, `str = None` is applied to `_field_no_pipe` in the `help` doctstring when you use the `rich.inspect(, help=True)` method on the `ui` object, no?

So, are you referring to the print out on line `535` of your example: `'_field_no_pipe', <class 'str'>`? This is where you feel it should display `str | None` instead, so future developers will know this field type can be `None` as well, correct? However, this is the obj `type` and not the `help` doctstring of the obj, correct? Again, thank you for feedback!

• ###### seraph776commented on "Storing information about the user" kumite

Thanks for the feedback. According to the Python docs, it uses this `| None = None` typehint only for `Init-only` variables. Please let me know your feedback if you agree or disagree ~ thanks!

• ###### seraph776commented on "Knight moves in 3 dimentions" kumite

You lose ~ 56 chars!😜

• ###### seraph776commented on "Flatten multi-nested list" kumite

I agree, this looks a lot better! However, you're still using a nested `for-loop` regardless of inverting the condition.

• ###### seraph776commented on "Knight moves in 3 dimentions" kumite

Good catch! According to StackOverflow, `O(n) + O(n log(n)) = O(n log(n))`. For Big O complexity, all that matters is the dominant term. `n log(n)` dominates `n` in this situation therefore, that's the only term that matters (source).

• ###### seraph776commented on "Knight moves in 3 dimentions" kumite

The time complexity of the `map()` function is `O(n)`.

• ###### seraph776commented on "Knight moves in 3 dimentions" kumite

The reason that we don't use constants with big O notation is because, theoretically they don't matter much. What we are calculating with time-complexity is the speed at which something will grow, having a constant on there will be completely irrelevant when a large enough input is used