thank you for the feedback, I have posted a fork of a previous translation with now completely updated code
C Fork kumited
Doing the C-version
I pass 128 or so, and I get a message like :
The expression (as strings) (major_scale(test_28)) == ("No major scale") is false: actual=`A# major scale` expected=`No major scale`.
I have no clue which one it is. I can of course print all the music strings I get, but I don't know which is test_28. The attempt doesn't stop with it hits an error, so somewhere in there is the debugging info I try print out.
Please - either display which music string is being tested or halt execution when hitting an error.
Oops, forgot to delete the line after testing... now all good :)
Please remove the line instead of commenting it out, so it wouldn't come as a false positive under grep ;-)
Fixed, thank you!
There is using namespace std; in C++ Preloaded section which should be removed. See: https://github.com/codewars/content-issues/wiki/List-of-Cpp-Kata-to-Update
using namespace std;
C++ version generates warnings.
C test code has compilation warnings.
Ah, oops! Thank you for pointing out :)
Shouldn't that sizeof(char**) in last malloc be sizeof(char*)
C++ Translation added, your review will be appreciated :)