Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Merged.
Merged.
It appears so. By mistake I generated a bunch of atoms, not strings. Too bad nobody notified me :(
I just pushed a fix that doesn't generate atoms.
Merged.
This appears to be fixed.
adapted
sure, how does that look?
done
fork
of course, thank you, one day I'll learn, lol
approved by someone.
approved by someone.
Should hopefully be fixed in the latest fork: https://www.codewars.com/kumite/6696a5690262be4c64dd00b9?sel=66974403e322e20079b01bc3
Thank you very much for such thorough review. It's not so common nowadays :P I'll go through each of the points in order, but before that, I just want you to know that I didn't write these tests (well, actually, I did, but I don't (want to) remember writing something so horrendous):
string.h
import is inevitable for such kata, so I'm inclined to keep it.As for replacing
sizeof(char)
with 1, I'm not sure I'm fully on-board with that. Yes, it's almost always (always?) 1, but addingsizeof
seems more explicit than just some magic number :P I would have to trust your judgement, and I think I do, but in this case it's not that big of a deal.Yes, there should be a few more functions to reduce redundancy, but at this point I'm just trying to make it functional and somewhat manageable.
I went ahead, jumped the gun, and approved the fixes in this fork: https://www.codewars.com/kumite/6696994cb9990c088ac6cf0b?sel=6696a5690262be4c64dd00b9
Let me know if I missed something important. Thanks!
Hi again. Apologies for not fixing the issue right away. I attempted to fix the issues and I'd appreciate if you could take a look:
Fix of the 2 desribed issues:
https://www.codewars.com/kumite/66965d54b52b86ee41c6cd36?sel=66965d54b52b86ee41c6cd36
Added additional
free
ing of pointers:https://www.codewars.com/kumite/66965d54b52b86ee41c6cd36?sel=669663617463769d8da21a68
Please let me know if this is acceptable or if I missed anything. Thanks!
Loading more items...