• Sign Up
    Time to claim your honor
  • Training
  • Practice
    Complete challenging Kata to earn honor and ranks. Re-train to hone technique
  • Freestyle Sparring
    Take turns remixing and refactoring others code through Kumite
  • Community
  • Leaderboards
    Achieve honor and move up the global leaderboards
  • Chat
    Join our Discord server and chat with your fellow code warriors
  • Discussions
    View our Github Discussions board to discuss general Codewars topics
  • About
  • Docs
    Learn about all of the different aspects of Codewars
  • Blog
    Read the latest news from Codewars and the community
  • Log In
  • Sign Up
xfix Avatar
Name:Konrad Borowski
Clan:Unknown
Member Since:Sep 2018
Last Seen:Nov 2020
Profiles:
Following:0
Followers:0
Allies:0
View Profile Badges
  • Stats
  • Kata
  • Collections
  • Kumite
  • Social
  • Discourse
  • Conversations (14)
  • Replies
  • Authored
  • Needs Resolution
  • Custom User Avatar
    • akar-0
    • commented on ""Pick peaks" Rust Translation"
    • 3 years ago

    I don't think it's a good practice in Rust to import inside a function.

    I think it's a good idea to use a tuple rather than an overwhelming struct or hashmap or whatever. However I would add an explicit note in solution set up so the user knows exactly what is expected in the tuple.

  • Custom User Avatar
    • username0
    • commented on ""Pick peaks" Rust Translation"
    • 5 years ago
    • bump Rust to 1.44
    • Change function signature to fn pick_peaks(nums: &[i32]) -> (Vec<usize>, Vec<i32>)
    • increase random test repeats from 40 to 100
    • Place sample tests inside tests module

    Didn't check any logic or test cases or description so careful review is necessary before approvings

  • Custom User Avatar
    • Unnamed
    • commented on ""Pick peaks" Rust Translation"
    • 5 years ago

    The definition of PosPeaks probably should be in the Preloaded section and in the kata description.
    arr isn't the best name for a non-array.

  • Custom User Avatar
    • hpwxf
    • commented on "Make a spiral" rust solution
    • 5 years ago

    No mutable! Congratulations!

  • Custom User Avatar
    • corebreaker
    • commented on "Make a spiral" rust solution
    • 5 years ago

    bravo, beautiful algorithm !

  • Custom User Avatar
    • user8436785
    • commented on ""Make a spiral" Rust Translation"
    • 5 years ago

    approved

  • Custom User Avatar
    • xfix
    • commented on ""Make a spiral" Rust Translation"
    • 5 years ago

    Done.

  • Custom User Avatar
    • user8436785
    • commented on ""Make a spiral" Rust Translation"
    • 5 years ago

    Merge conflict--fork and update the description.

  • Custom User Avatar
    • user8436785
    • commented on ""Make a spiral" Rust Translation"
    • 5 years ago

    Yes, that's what I meant.

  • Custom User Avatar
    • xfix
    • commented on ""Make a spiral" Rust Translation"
    • 5 years ago

    Done - worth noting I based my translation on Java tests, which don't separate tests for 5..10 and 11..50, but I hope I understood what you meant here.

  • Custom User Avatar
    • imjasonmiller
    • commented on ""Make a spiral" Rust Translation"
    • 5 years ago

    That's great news. Thanks a lot for the headsup @stɛffan153! Have a great day.

  • Custom User Avatar
    • user8436785
    • commented on ""Make a spiral" Rust Translation"
    • 5 years ago

    Actual and expected are reversed in test_5_through_50.
    Also, to match with the Python tests, please use assert_eq! (what you have now) for 5..10, but for 11..50, use assert! and == so the user can't see the expected value => harder to hardcode.

  • Custom User Avatar
    • user8436785
    • commented on ""Make a spiral" Rust Translation"
    • 5 years ago

    Yes, anyone with 4k+ honor can approve other translations.
    Note: if the author was active less than a month ago, the translation has to be at least 1 week old first.
    I'll have a look at it + the Julia translation.

  • Custom User Avatar
    • imjasonmiller
    • commented on ""Make a spiral" Rust Translation"
    • 5 years ago

    I thought I'd add the translation, but found you had already submitted it! :-)

    It unfortunately seems the kata author @Bugari hasn't visited the site for quite some time. Is there perhaps an alternative mechanism to approve translations?

  • © 2025 Codewars
  • About
  • API
  • Blog
  • Privacy
  • Terms
  • Code of Conduct
  • Contact

Confirm

  • Cancel
  • Confirm

Collect: undefined

Loading collection data...