This solution is clearly wrong as can be seen by testing it with inputs (1,2,3) (expected 0, produces 1) and (1,-2,-3) (expected 0, produces 1). Nevertheless, it passes the test suite every last time. Might I suggest adding an element of randomness into the testing so that c is not always 1 or 0?
There's an error in one js test error message assert.strictEqual(twoArePositive(-4, 6, 0), false, '(4, -6, 9)'); should be assert.strictEqual(twoArePositive(-4, 6, 0), false, '(4, -6, 0)');
Well seeing all the beginners struggle with this kata I would say there is clearly a demand for it. The only thing which is off is the rating of 7 kyu while it should clearly be an 8 but that's already too late.
Fixed.
This solution is clearly wrong as can be seen by testing it with inputs
(1,2,3)
(expected0
, produces1
) and(1,-2,-3)
(expected0
, produces1
). Nevertheless, it passes the test suite every last time. Might I suggest adding an element of randomness into the testing so thatc
is not always1
or0
?C++ Translation
possibly actually reading the description is a novel idea for them. but that's no reason to have this kata; any other kata will do.
approved
Downvoting and not explaining why is just lazy
Approved.
Fixed.
There's an error in one js test error message
assert.strictEqual(twoArePositive(-4, 6, 0), false, '(4, -6, 9)');
should beassert.strictEqual(twoArePositive(-4, 6, 0), false, '(4, -6, 0)');
nitpick: a minor typo in the description
two of [of] the three
.Not anymore. Test cases have been updated.
Added also for C#.
Approved by someone
Well seeing all the beginners struggle with this kata I would say there is clearly a demand for it. The only thing which is off is the rating of 7 kyu while it should clearly be an 8 but that's already too late.
Loading more items...