Fixed it

I noticed that inaccuracy too. The JS version is wrong.

thanks for the feedback!

I think using the language's built in functions should be allowed. The python solution allows it's itertools permutations function as well.

I would also like to compliment you on your translation of this Kata. This is very clean, well implemented, and correct as far as I can tell.

Please reach out to me on linkedin https://il.linkedin.com/in/michaelsalaverry

That's normal, it's because a vector size is not the same type as an integer, but nevermind, it still works.

That's how security vulnerabilities, and a bunch of other problems, is born :)

In general don't worry about warnings in C/C++ (though they may provide useful information for debugging when a program if it doesn't work properly)

And what if program does not work properly in a way you haven't noticed it? Compilation logs become suddenly a topic of interest when hunting for ghost bugs :)

That's normal, it's because a vector size is not the same type as an integer, but nevermind, it still works. In general don't worry about warnings in C/C++ (though they may provide useful information for debugging when a program if it doesn't work properly), only errors are fatal for a program.

return in tuple

fixed !

... or not, the kata got locked while i was clearing the warnings, i reopen the issue

fixed !

I don't know if that's what that sentence means, I think it was more like this case: two_sum([1,1,3], 4)) and [0,2] and [1,2] being valid. In any case, it should be clarified if index1 is expected to be less than index2.

I have the same issue. Can you tell me how to deal with it?

Approved again. Thx for fixing.

Approved, thanks